-
Notifications
You must be signed in to change notification settings - Fork 12
fix: CLI command text review #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of suggestions, but overall this seems good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moorejacqueline , the help looks awesome! Very nice job.
Most of my comments are either suggestions for adding a tad more information to help the user, or me being a bit confused about wording, possibly because I'm just not that familiar with LWC. I have a few direct edits, but nothing big.
Important: please make sure that the site.ts
file is updated to show the command description (i added a comment) -- currently, because the crucial line was removed, the --help
isn't showing any command description at all.
Happy to do a second review after you deal with my first review, but only if you want -- it's not necessary. Cheers!
@nrkruk @jshackell-sfdc noticed the |
9ee6c64
to
5b5336d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@moorejacqueline , see a few little edits, nothing big. Otherwise, the help looks great!
I'm sure devs are on it, but just for completeness, I noticed these two things:
- the command
lightning preview component
is still showing up when I runsf lightning preview --help
; I think it needs to be hidden? - These commands are going out as beta first, right? If so, they should be marked as such in the code; see https://github.com/salesforcecli/plugin-devops-center/blob/main/src/commands/project/deploy/pipeline/quick.ts#L20 for an example.
Thanks!
FYI @nrkruk
Co-authored-by: Juliet Shackell <63259011+jshackell-sfdc@users.noreply.github.com>
What does this PR do?
Suggest revisions to
--help
text forlightning preview app
andlightning preview site
to make sure content aligns with CX standards.What issues does this PR fix or reference?
@W-15924073@